Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for constraint framework #22219

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

feilong-liu
Copy link
Contributor

Description

Add test mentioned in #22171 so as to avoid reintroducing the same problem.

Motivation and Context

To avoid reintroduce the same problem

Impact

Avoid potential bug

Test Plan

Change is only in test

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

Add test mentioned in prestodb#22171
so as to avoid reintroducing the same problem.
Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test

@feilong-liu feilong-liu merged commit 8e82ee4 into prestodb:master Mar 15, 2024
55 of 56 checks passed
@feilong-liu feilong-liu deleted the add_test branch March 15, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants