Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
SqlToRowExpressionTranslator
will attempt to optimize queries that contain like that begin and end with % as follows:as
select cardinality(split(...charcol...))
This doesn't work because
split
is only registered forVARCHAR
, notCHAR
.Motivation and Context
Any query that attempts to do
LIKE '%text%'
over a char column is broken.Impact
Restore functionality and backport into 0.284, 0.285 and prepare for 0.286.
Test Plan
Attached unit tests.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.