Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggering of RcFilePageSourceFactory logic for non-RC tables #22066

Closed

Conversation

sdruzkin
Copy link
Collaborator

@sdruzkin sdruzkin commented Mar 2, 2024

Description

Logic in RcFilePageSourceFactory must be only applicable for RC tables.
However in the current implementation the RcFilePageSourceFactory logic
for checking partially aggregation pushdowns is triggered before making
sure the table has RC format. As result if ORC or Parquet batch reader factories
are placed after the RC factory, then the logic in the RC factory will incorrectly
fail the query.

Motivation and Context

See description.

Impact

No impact.

Test Plan

Existing tests.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@sdruzkin sdruzkin requested a review from a team as a code owner March 2, 2024 03:54
@sdruzkin sdruzkin requested a review from presto-oss March 2, 2024 03:54
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems significant enough a fix to justify an issue, release notes, and a test.

@sdruzkin
Copy link
Collaborator Author

sdruzkin commented Mar 2, 2024

This seems significant enough a fix to justify an issue, release notes, and a test.

This will only manifest itself if the order of page source factories in connector is such that ORC and Parquet are coming after the RC, meaning that you won't find it on a typical deployment. I found it after making Alpha page source factory compatible with the partial aggregation.

@rschlussel
Copy link
Contributor

this should be fixed by #22011

@sdruzkin sdruzkin closed this Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants