[native] Prepare for the exchange protocol upgrade #21995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76b6c1c to
016f913
Compare
|
Crash in Pending fix: facebookincubator/velox#8850 |
mbasmanova
reviewed
Feb 26, 2024
mbasmanova
reviewed
Feb 26, 2024
mbasmanova
previously approved these changes
Feb 26, 2024
There was a problem hiding this comment.
@Yuhta Looks great. Thanks. Please, confirm that presto_protocol.h/cpp files were auto-generated and not modified by hand.
1add3e2 to
f6d8dac
Compare
mbasmanova
previously approved these changes
Feb 26, 2024
0f774ae to
3c7a776
Compare
This is the change needed on presto_cpp side to implement the new exchange protocol. Implement `ExchangeSource::getDataSizes` and use it when the header `X-Presto-Get-Data-Size` exists (will be removed in the future once coordinator support the `HEAD` calls), or the endpoint is called with HTTP `HEAD` method. All changes here are backward-compatible. The new protocol will not be used until we start calling `getDataSizes` on velox side in `ExchangeClient`. See prestodb#21926 for details about design of the new protocol. Also added new runtime stats `numTopOutputBuffers`.
3c7a776 to
ba9daab
Compare
mbasmanova
approved these changes
Feb 27, 2024
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the change needed on presto_cpp side to implement the new exchange protocol. Implement
ExchangeSource::getDataSizesand use it when the headerX-Presto-Get-Data-Sizeexists (will be removed in the future once coordinator support theHEADcalls), or the endpoint is called with HTTPHEADmethod.All changes here are backward-compatible. The new protocol will not be used until we start calling
getDataSizeson velox side inExchangeClient.See #21926 for details about design of the new protocol.
Also added new runtime stats
numTopOutputBuffers.