Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Preserve case for RowType's field name and JSON content when CAST" #21866

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

ajaygeorge
Copy link
Contributor

@ajaygeorge ajaygeorge commented Feb 5, 2024

This reverts commit d5a31b3.

Description

This reverts the commit d5a31b3.
which was causing issues with user queries.
See discussion in #21602 (comment)

Test Plan

Unit Tests

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@ajaygeorge ajaygeorge requested a review from a team as a code owner February 5, 2024 20:04
@ajaygeorge ajaygeorge requested a review from presto-oss February 5, 2024 20:04
@ajaygeorge
Copy link
Contributor Author

@hantangwangd Let us add a legacy_json_cast flag in #21602 to preserve the original behavior since this is impacting user queries.

@NikhilCollooru
Copy link
Contributor

Having a flag to control a changed behavior is better. Approving this revert. @hantangwangd please send a new PR that provides a flag to control this . Thanks !

Copy link
Contributor

@jainxrohit jainxrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hantangwangd
Copy link
Member

OK, I will do this. Thanks for your suggestion. @ajaygeorge @NikhilCollooru

@ajaygeorge ajaygeorge merged commit 4ed9b52 into prestodb:master Feb 6, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants