Upgrade Iceberg from 1.0.0 to 1.1.0 #18709
Conversation
b8e3bec to
2476ce1
Compare
| @@ -146,15 +146,15 @@ private static List<Page> buildPages(ConnectorTableMetadata tableMetadata, Conne | |||
| .filter(entry -> idToTypeMap.containsKey(entry.getKey())) | |||
| .collect(toImmutableMap( | |||
| Map.Entry<Integer, ByteBuffer>::getKey, | |||
| entry -> Transforms.identity(idToTypeMap.get(entry.getKey())).toHumanString( | |||
| entry -> Transforms.identity().toHumanString(idToTypeMap.get(entry.getKey()), | |||
There was a problem hiding this comment.
Transforms.identity(<type>) has been deprecated and will be removed in 2.0.0, so we can change it now to lazy bind to the given type
| assertEquals(Transforms.month(DateType.get()).toString(), "month"); | ||
| assertEquals(Transforms.day(DateType.get()).toString(), "day"); | ||
| assertEquals(Transforms.hour(TimestampType.withoutZone()).toString(), "hour"); | ||
| assertEquals(Transforms.identity().toString(), "identity"); |
There was a problem hiding this comment.
specifying the type has been deprecated and will be removed in 2.0.0. The type is only needed at bind time, so we can use the new APIs here rather than waiting until this will be removed
2476ce1 to
922ce61
Compare
922ce61 to
fe56b41
Compare
fe56b41 to
385132a
Compare
|
@ChunxuTang this should be ready for review |
| assertEquals(Transforms.month(DateType.get()).toString(), "month"); | ||
| assertEquals(Transforms.day(DateType.get()).toString(), "day"); | ||
| assertEquals(Transforms.hour(TimestampType.withoutZone()).toString(), "hour"); | ||
| assertEquals(Transforms.identity().toString(), "identity"); |
| // nessie writes a "nessie.commit.id" to the table properties | ||
| assertThat(materializedRows).hasSize(2); | ||
| // nessie writes a "nessie.commit.id" + "gc.enabled=false" to the table properties | ||
| assertThat(materializedRows).hasSize(3); |
There was a problem hiding this comment.
Just for confirmation: You updated the size from 2 to 3. Is it because you are adding gc.enabled=false to the properties?
There was a problem hiding this comment.
Thanks for the clarification!
|
Looks like Iceberg 1.1.0 has been officially released (https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.1.0), I'm merging this PR. Cc @nastra |
Iceberg-related release notes haven't been published yet, but here's an overview of changes that made it into Iceberg 1.1.0: https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.1.0