-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support of MAP_REMOVE_NULL_VALUES for Presto #18675
Conversation
@bot kick off tests |
Maybe call it MAP_REMOVE_NULL_VALUES? Not sure. Also add documentation |
I think MAP_REMOVE_NULLS also works given keys can't be null. Also users can always refer to documentation if they have doubts. Let me add documentation. |
ab98a21
to
68c35c6
Compare
Documentation added. |
No we should be explicit as far as possible users should understand without any other knowledge. So I say call it MAP_REMOVE_NULL_VALUES |
OK |
30c6827
to
0842bc0
Compare
...n/src/test/java/com/facebook/presto/operator/scalar/sql/TestMapRemoveNullValuesFunction.java
Outdated
Show resolved
Hide resolved
5c7d8c8
to
d0639aa
Compare
Can we merge this one? |
Adding support of
MAP_REMOVE_NULL_VALUES
for Presto.map_remove_null_values(map(K, V)) -> map(K, V)
Test plan
Added unit tests.
Build successfully using the following terminal command
mvn -Dtest=TestMapRemoveNullValuesFunction test