-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for ARRAY_SORT_DESC to Presto #18660
Conversation
7e4df46
to
30aa812
Compare
Formatting release notes |
65a38c3
to
1a54204
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release note is too verbose. We only need one (long) line to explain what it does in English. Also, we need :func:
annotation for the function name so it can be linked to the doc you wrote.
presto-main/src/test/java/com/facebook/presto/operator/scalar/sql/TestArraySqlFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/operator/scalar/sql/TestArraySqlFunctions.java
Outdated
Show resolved
Hide resolved
presto-main/src/test/java/com/facebook/presto/operator/scalar/sql/TestArraySqlFunctions.java
Outdated
Show resolved
Hide resolved
@bot kick off tests |
dd9fa85
to
a070060
Compare
Done! |
Can we merge this PR? |
Adding an UDF for sorting array elements in the descending order. The elements of array must be orderable. Null elements will be placed at the end of the returned array.
array_sort_desc(array(T)) -> array(T)
Test plan
Added unit tests.
Build successfully using the following terminal command
mvn -Dtest=TestArraySqlFunctions install