Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Disaggregated Coordinator Weighted Scheduling #18595

Conversation

swapsmagic
Copy link
Contributor

Resource group manager was considering locally running queries count to decide on the group weight and prioritze next running query or eligible group. With the fix, it considers all queries running in the cluster for a given resource group to decide the scheduling weight.

Test plan - unit test

== RELEASE NOTES ==

General Changes
* Fix weighted scheduling for disaggregated coordinator

@swapsmagic swapsmagic requested a review from a team as a code owner October 31, 2022 23:44
@swapsmagic swapsmagic requested a review from presto-oss October 31, 2022 23:44
@swapsmagic swapsmagic changed the title Fix Disaggregated Coordinator Weighted Scheduling Fix Fix Disaggregated Coordinator Weighted Scheduling Oct 31, 2022
@swapsmagic swapsmagic force-pushed the disagg_coordinator_weighted_scheduling_fix branch 2 times, most recently from 0eb2c13 to 3261013 Compare November 1, 2022 16:47
Resource group manager was considering locally running queries count to decide on the group weight
and prioritze next running query or eligible group. With the fix, it considers all queries running in
the cluster for a given resource group to decide the scheduling weight.
@swapsmagic swapsmagic force-pushed the disagg_coordinator_weighted_scheduling_fix branch from 3261013 to 5b7fde3 Compare November 1, 2022 17:48
@swapsmagic swapsmagic requested a review from a team November 2, 2022 22:15
@tdcmeehan tdcmeehan merged commit 208b60e into prestodb:master Nov 2, 2022
@wanglinsong wanglinsong mentioned this pull request Jan 12, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants