Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page retained size by accounting slice base object once for a page #17641

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

singcha
Copy link
Contributor

@singcha singcha commented Apr 13, 2022

Test plan -
Tested with Presto on Spark failing broadcast queries & Presto small & large queries in production

== RELEASE NOTES ==

General Changes
* Fix a memory overcounting issue for using varchar types that could cause queries to fail with exceeded memory limit errors.

Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Copy link
Contributor

@highker highker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good if @rschlussel can help to take another look.

@highker highker self-assigned this Apr 13, 2022
Copy link
Contributor

@rschlussel rschlussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from existing comments.

@rschlussel
Copy link
Contributor

rschlussel commented Apr 14, 2022

Also, looks like some of the code was taken from #10633. you should give attribution to the author in the commit message. You can use these guidelines: https://github.com/prestodb/presto/wiki/Review-and-Commit-guidelines#attribution

@rschlussel
Copy link
Contributor

You have a checkstyle violation: Error: src/test/java/com/facebook/presto/execution/buffer/TestPagesSerde.java:[138,48] (whitespace) WhitespaceAfter: ',' is not followed by whitespace.

Fix page retained size by accounting slice base object once for a page

Co-Authored-By: Karol Sobczak <napewnotrafi@gmail.com>
@highker highker requested a review from NikhilCollooru April 14, 2022 21:23
@highker highker merged commit bdb2184 into prestodb:master Apr 15, 2022
@mshang816 mshang816 mentioned this pull request May 17, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants