-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix page retained size by accounting slice base object once for a page #17641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
presto-common/src/main/java/com/facebook/presto/common/Page.java
Outdated
Show resolved
Hide resolved
presto-common/src/main/java/com/facebook/presto/common/block/VariableWidthBlock.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be good if @rschlussel can help to take another look.
presto-main/src/test/java/com/facebook/presto/execution/buffer/TestPagesSerde.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside from existing comments.
presto-common/src/main/java/com/facebook/presto/common/block/VariableWidthBlock.java
Outdated
Show resolved
Hide resolved
Also, looks like some of the code was taken from #10633. you should give attribution to the author in the commit message. You can use these guidelines: https://github.com/prestodb/presto/wiki/Review-and-Commit-guidelines#attribution |
You have a checkstyle violation: Error: src/test/java/com/facebook/presto/execution/buffer/TestPagesSerde.java:[138,48] (whitespace) WhitespaceAfter: ',' is not followed by whitespace. |
Fix page retained size by accounting slice base object once for a page Co-Authored-By: Karol Sobczak <napewnotrafi@gmail.com>
Test plan -
Tested with Presto on Spark failing broadcast queries & Presto small & large queries in production