Enhance assertQuery to support actual and expected session parameters. #17626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbasmanova
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
@amitkdutta Looks good % typo in commit message: supoprt -> support
yuanzhanhku
approved these changes
Apr 11, 2022
|
@amitkdutta Amit, would you fix typo in the commit message so we can merge this? |
tdcmeehan
approved these changes
Apr 11, 2022
fccad62 to
8633593
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to pass different session properties for
assertQueryfunction. This is particularly useful when we want to test a query result with different session config. One example is native worker supports merge join, and we want to validate merge join's result in a test with other join. This PR will allow us to write such tests.