Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thrift support for SplitOperatorInfo #17604

Merged
merged 4 commits into from
Apr 18, 2022
Merged

Add thrift support for SplitOperatorInfo #17604

merged 4 commits into from
Apr 18, 2022

Conversation

ajaygeorge
Copy link
Contributor

@ajaygeorge ajaygeorge commented Apr 7, 2022 •
edited
Loading

  • Add info map to ConnectorSplit
  • Use the new getInfoMap method from ConnectorSplit
  • Use the info map from Split in operators
  • Add thrift serde support for SplitOperatorInfo

Test plan - Unit tests and Verifier tests https://www.internalfb.com/intern/presto/verifier/results/?test_id=78132

== RELEASE NOTES ==

SPI Changes
* Add `getInfoMap` method in `ConnectorSplit` which returns a `Map<String, String>`. This method should be preferred to the `getInfo` method which returns a raw object.

@ajaygeorge ajaygeorge force-pushed the split_operator_info branch 2 times, most recently from 181956f to 8524345 Compare April 7, 2022 21:29
@ajaygeorge ajaygeorge requested a review from tdcmeehan April 7, 2022 22:18
@ajaygeorge ajaygeorge force-pushed the split_operator_info branch from 8524345 to 3a85cd3 Compare April 12, 2022 21:37
@ajaygeorge
Add info map to ConnectorSplit
8ec3ab7
@ajaygeorge
Use the new getInfoMap method from ConnectorSplit

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
82c5efe
@ajaygeorge
Use the info map from Split in operators
e2894e8
@ajaygeorge
Add thrift serde support for SplitOperatorInfo
8db70b5
@ajaygeorge ajaygeorge force-pushed the split_operator_info branch from 3a85cd3 to 8db70b5 Compare April 14, 2022 20:14
@tdcmeehan tdcmeehan merged commit 158c8d5 into prestodb:master Apr 18, 2022
@mshang816 mshang816 mentioned this pull request May 17, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdcmeehan tdcmeehan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajaygeorge @tdcmeehan