clickhouse connector #17596
Merged
clickhouse connector #17596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhenxiao
requested changes
Apr 6, 2022
presto-clickhouse/pom.xml
Outdated
| <groupId>com.facebook.presto</groupId> | ||
| <version>0.273-SNAPSHOT</version> | ||
| </parent> | ||
| <modelVersion>4.0.0</modelVersion> |
There was a problem hiding this comment.
modelVersion above parent
| private static final String TempTableNamePrefix = "tmp_presto_"; | ||
| protected final String connectorId; | ||
| protected final ConnectionFactory connectionFactory; | ||
| protected static final String identifierQuote = "\""; |
There was a problem hiding this comment.
let's put static final constants together. put identifierQuote just below TempTableNamePrefix
| .put(TIMESTAMP, "timestamp") | ||
| .put(TIMESTAMP_WITH_TIME_ZONE, "timestamp with timezone") | ||
| .build(); | ||
| private static final String TempTableNamePrefix = "tmp_presto_"; |
There was a problem hiding this comment.
s/TempTableNamePrefix/tempTableNamePrefix/g
| columns.add(new ClickHouseColumnHandle(connectorId, columnName, typeHandle, columnMapping.get().getType(), nullable)); | ||
| } | ||
| else { | ||
| System.out.println("The clickHouse datatype: " + typeHandle.getJdbcTypeName() + " unsupported."); |
There was a problem hiding this comment.
use log.info, instead of System out
| public void abortReadConnection(Connection connection) | ||
| throws SQLException | ||
| { | ||
| // most drivers do not need this |
There was a problem hiding this comment.
let's remove this comment
| skipTestUnless(supportsNotNullColumns()); | ||
|
|
||
| String catalog = getSession().getCatalog().get(); | ||
| // String createTableStatement = "CREATE TABLE " + catalog + ".tpch.test_not_null_with_insert (\n" + |
There was a problem hiding this comment.
let's remove all these commented code
| assertQueryFails("INSERT INTO test_not_null_with_insert (column_a) VALUES (date '2012-12-31')", "(?s).*NULL.*column_b.*"); | ||
| assertQueryFails("INSERT INTO test_not_null_with_insert (column_a, column_b) VALUES (date '2012-12-31', null)", "(?s).*NULL.*column_b.*"); | ||
|
|
||
| //assertUpdate("ALTER TABLE test_not_null_with_insert ADD COLUMN column_c BIGINT NOT NULL"); |
| assertUpdate("DROP TABLE test_not_null_with_insert"); | ||
| } | ||
|
|
||
| // |
| ==================== | ||
|
|
||
| The ClickHouse connector allows querying tables in an external | ||
| `Yandex ClickHouse <https://clickhouse.tech/>`_ server. This can be used to |
| To connect to a ClickHouse server, you need: | ||
|
|
||
| * ClickHouse version 20.8 or higher. | ||
| * Network access from the Trino coordinator and workers to the ClickHouse |
0db1e35 to
5b4f057
Compare
zhenxiao
approved these changes
Apr 24, 2022
| private String toWriteMapping(Type type) | ||
| { | ||
| if (type == BOOLEAN) { | ||
| // ClickHouse is no separate type for boolean values. Use UInt8 type, restricted to the values 0 or 1. |
There was a problem hiding this comment.
rephrase the comment to:
ClickHouse uses UInt8 as boolean, restricted values to 0 and 1
| return "String"; | ||
| } | ||
| if (type instanceof VarbinaryType) { | ||
| // Strings of an arbitrary length. The length is not limited |
There was a problem hiding this comment.
comment:
Strings of arbitrary length.
| return userCredentialName; | ||
| } | ||
|
|
||
| @Config("clickhouse.user-credential-name") |
| STRIPELOG("StripeLog"), | ||
| LOG("Log"), | ||
| TINYLOG("TinyLog"), | ||
| MERGETREE("MergeTree()"), |
...to-clickhouse/src/main/java/com/facebook/presto/plugin/clickhouse/ClickhouseDXLKeyWords.java
Show resolved
Hide resolved
| } | ||
|
|
||
| @Config("clickhouse.password-credential") | ||
| public ClickHouseConfig setPasswordCredentialName(String passwordCredentialName) |
There was a problem hiding this comment.
s/setPasswordCredentialName/setPasswordCredential/g
| return userCredentialName; | ||
| } | ||
|
|
||
| @Config("clickhouse.user-credential-name") |
There was a problem hiding this comment.
s/setUserCredentialName/setUserCredential/g
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== RELEASE NOTES ==
General Changes