Pinot connector: by default turn on push down top n queries #17582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config was off as Pinot version < 0.4 doesn't support aggregation group by order by, so the
order by
can not be pushdown. We need to retrieve many groups then let presto order it.Since Pinot supports ORDER BY now, this clause can now be pushed down by default.
For example, for presto query
SELECT Origin, sum(AirTime) FROM airlineStats GROUP BY Origin ORDER BY Origin LIMIT 10
the generated Pinot queries to push down are:
When the config is turned off (
pinot.pushdown-topn-broker-queries=false
):After the config is turned on (
pinot.pushdown-topn-broker-queries=true
):