Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iceberg $properties system table #17509

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Add iceberg $properties system table #17509

merged 1 commit into from
Mar 24, 2022

Conversation

ChunxuTang
Copy link
Member

Add iceberg $properties system table
Cherry-pick of trinodb/trino@8abb12f

Co-Authored-By: Victoria Bukta victoria.bukta@shopify.com

== RELEASE NOTES ==

Iceberg Changes
* Add $properties system table

@ChunxuTang
Add iceberg $properties system table
cd68273 
Cherry-pick of trinodb/trino@8abb12f

Co-Authored-By: Victoria Bukta <victoria.bukta@shopify.com>
@ChunxuTang
Copy link
Member Author

Quick note:
The cherry-picked PR tests the new column in the BaseIcebergConnectorTest.java file (our TestAbstractIcebergSmoke.java file correspondingly). But as the PR adds a new column in the Iceberg system table, I prefer to add the test in the TestIcebergSystemTables.java file.

@ChunxuTang
Copy link
Member Author

Hi @beinan and @zhenxiao, would you mind taking a look at this PR? Thanks!

beinan
beinan approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@beinan beinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@beinan beinan merged commit 04cf685 into prestodb:master Mar 24, 2022
@mshang816 mshang816 mentioned this pull request May 17, 2022
Merged
14 tasks
@ChunxuTang ChunxuTang deleted the iceberg-property branch July 10, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beinan beinan beinan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChunxuTang @beinan