Implement subfield acl check #17475
Merged
Implement subfield acl check #17475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19d498e to
808ed7a
Compare
808ed7a to
ff6a104
Compare
highker
approved these changes
Mar 16, 2022
presto-main/src/main/java/com/facebook/presto/sql/analyzer/Analysis.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/analyzer/Analysis.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/analyzer/Analysis.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
Comment on lines
+1375
to
+1377
| if (baseType == null || !(baseType instanceof RowType)) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
!(baseType instanceof RowType) implies baseType == null
There was a problem hiding this comment.
Why? This is for subscript, it could be array/map
|
Also remember we have indexed access to fields x[n]is same as x.a if a is the n-th field in the struct. |
Yeah, I added tests for this |
54c65d9 to
8ead1b4
Compare
8ead1b4 to
ec0a89f
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to enable fine grained column subfield acl check. If we query col.x, we send "col.x" to permission server for access control checks, rather than just "col".
Also noticed that UtilizedColumnReferenceAnalyzer had a bug with dereference expressions. I fixed it(one liner) and I guess people weren't relying on it.
After fixing it, UtilizedColumnReferenceAnalyzer implementation still doesn't work perfectly with subfields, as it doesn't prune unused subfields(added a test with explanation), but the implementation should be more than enough to push it like this, especially given the fact that it was already buggy before.