Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer size calculation in TDigest #17456

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix buffer size calculation in TDigest #17456

merged 1 commit into from
Mar 11, 2022

Conversation

tdcmeehan
Copy link
Contributor

@tdcmeehan tdcmeehan commented Mar 10, 2022 •
edited
Loading

Test plan - Attempted to reproduce an off by one error with the following fix. It succeeded, proving the fix works.

== RELEASE NOTES ==

General Changes
* Fix an error in ``tdigest_agg``

@tdcmeehan tdcmeehan changed the title [WIP] Fix buffer size calculation in TDigest Fix buffer size calculation in TDigest Mar 10, 2022
@tdcmeehan tdcmeehan requested a review from a team March 10, 2022 23:11
@tdcmeehan tdcmeehan merged commit b21d4fd into prestodb:master Mar 11, 2022
@mshang816 mshang816 mentioned this pull request May 17, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunthirupathi arunthirupathi arunthirupathi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdcmeehan @arunthirupathi