Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double quote identifier in generated pinot query #17276

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Double quote identifier in generated pinot query #17276

merged 1 commit into from
Apr 7, 2022

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 9, 2022 •
edited
Loading

Always double-quoting identifiers to concur the problem that some column names in pinot are reserved keywords and Pinot query parser throwing exceptions on those scenarios.

Test plan - (Please fill in how you tested your changes)
Unit tests

== RELEASE NOTES ==

Pinot Changes
* Always double-quotes identifiers in generated Pinot queries.

@xiangfu0 xiangfu0 marked this pull request as draft February 9, 2022 23:06
@xiangfu0
Copy link
Contributor Author

Will update this once Pinot driver is upgraded to 0.10.0. Double quotes are not accepted by PQL.

@xiangfu0 xiangfu0 force-pushed the pinot-double-quote-identifier branch from caa12a0 to e290a5f Compare April 5, 2022 21:58
@xiangfu0 xiangfu0 marked this pull request as ready for review April 5, 2022 22:35
@xiangfu0 xiangfu0 force-pushed the pinot-double-quote-identifier branch from e290a5f to 88031be Compare April 6, 2022 03:55
@xiangfu0 xiangfu0 force-pushed the pinot-double-quote-identifier branch from 88031be to 99db19e Compare April 6, 2022 05:57
@xiangfu0
Copy link
Contributor Author

xiangfu0 commented Apr 7, 2022

@highker

@highker highker merged commit 89cd990 into prestodb:master Apr 7, 2022
@xiangfu0 xiangfu0 deleted the pinot-double-quote-identifier branch April 7, 2022 19:11
@mshang816 mshang816 mentioned this pull request May 17, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@highker highker highker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangfu0 @highker