Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for UUID in PostgreSQL connector #16875

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Add support for UUID in PostgreSQL connector #16875

merged 1 commit into from
Dec 20, 2022

Conversation

agrawalreetika
Copy link
Member

@agrawalreetika agrawalreetika commented Oct 14, 2021 •
edited
Loading

Fixes #16817

== RELEASE NOTES ==

PostgreSQL Connector Changes#
* Add support for PostgreSQL UUID Data type

@agrawalreetika agrawalreetika force-pushed the UUID-datatype branch 2 times, most recently from 8683294 to 600ffa3 Compare October 14, 2021 14:50
@stale
Copy link

stale bot commented Jun 13, 2022

This pull request has been automatically marked as stale because it has not had recent activity. If you'd still like this PR merged, please comment on the task, make sure you've addressed reviewer comments, and rebase on the latest master. Thank you for your contributions!

@stale stale bot added the stale label Jun 13, 2022
@agrawalreetika agrawalreetika requested a review from a team as a code owner November 4, 2022 05:20
@agrawalreetika agrawalreetika force-pushed the UUID-datatype branch 2 times, most recently from a525f36 to 6f55ccd Compare November 7, 2022 06:18
@ClarenceThreepwood
Copy link
Contributor

@agrawalreetika - Unable to check out your code. I get the error "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository". Could you please validate whether this PR was based off a legitimate branch?

@agrawalreetika
Copy link
Member Author

@agrawalreetika - Unable to check out your code. I get the error "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository". Could you please validate whether this PR was based off a legitimate branch?

Hi @ClarenceThreepwood, Thanks for taking the time to review the PR. I think you are looking at a different fork since my prestodb fork has a branch available - https://github.com/agrawalreetika/prestodb/tree/UUID-datatype

@ethanyzhang
Copy link
Contributor

@ClarenceThreepwood You probably need to add Reetika's fork as a remote in your local repo.

ClarenceThreepwood
ClarenceThreepwood approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@ClarenceThreepwood ClarenceThreepwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits. Otherwise LGTM

...ostgresql/src/test/java/com/facebook/presto/plugin/postgresql/TestPostgreSqlTypeMapping.java Outdated
.addRoundTrip(uuidDataType, "71f9206a-75aa-4005-9ab6-4525c6fdec99");
}

public static DataType<String> uuidDataType()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make private

presto-base-jdbc/src/main/java/com/facebook/presto/plugin/jdbc/BaseJdbcClient.java
@@ -107,6 +108,7 @@
.put(TIME_WITH_TIME_ZONE, "time with timezone")
.put(TIMESTAMP, "timestamp")
.put(TIMESTAMP_WITH_TIME_ZONE, "timestamp with timezone")
.put(UuidType.UUID, "uuid")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static import UUID

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is UUID import from util package exist in this class, which is why I didn't use static import for this

@yingsu00 yingsu00 self-assigned this Dec 19, 2022
@tdcmeehan tdcmeehan merged commit 03938b4 into prestodb:master Dec 20, 2022
@wanglinsong wanglinsong mentioned this pull request Jan 12, 2023
Merged
30 tasks
@agrawalreetika agrawalreetika deleted the UUID-datatype branch June 7, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaneja aaneja aaneja approved these changes

@tdcmeehan tdcmeehan tdcmeehan approved these changes

@ClarenceThreepwood ClarenceThreepwood ClarenceThreepwood approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees

@yingsu00 yingsu00

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for UUID in PostgreSQL connector
7 participants
@agrawalreetika @ClarenceThreepwood @ethanyzhang @aaneja @tdcmeehan @rohanpednekar @yingsu00