Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Native] Getting build issue after rebasing to latest Presto - 0.290-SNAPSHOT #23528

Closed
agrawalreetika opened this issue Aug 27, 2024 · 3 comments
Closed

[Native] Getting build issue after rebasing to latest Presto - 0.290-SNAPSHOT #23528

agrawalreetika opened this issue Aug 27, 2024 · 3 comments
Assignees
@majetideepak
Labels
build prestissimo Presto Native Execution

Comments

@agrawalreetika
Copy link
Member

agrawalreetika commented Aug 27, 2024 •
edited
Loading

I am encountering below error while building presto-native-execution after upgrading Presto to latest - 0.290-SNAPSHOT.
Only changes happened from my last successful build (i.e. on 0.289) are :

  • Mac OS Upgrade
  • Did Presto reabse to latest - 0.290-SNAPSHOT
[830/1229] Building CXX object velox/velox/connectors/hive/iceberg...eFiles/velox_hive_iceberg_splitreader.dir/IcebergSplitReader.cpp.o
FAILED: velox/velox/connectors/hive/iceberg/CMakeFiles/velox_hive_iceberg_splitreader.dir/IcebergSplitReader.cpp.o
ccache /Library/Developer/CommandLineTools/usr/bin/c++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DFOLLY_HAVE_INT128_T=1 -DGFLAGS_IS_A_DLL=0 -DVELOX_ENABLE_PARQUET -DVELOX_ENABLE_S3 -I/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/. -I/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox -I/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/external/xxhash -I/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/_build/debug/velox -I/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/_build/debug -I/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/. -I/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/_build/debug/_deps/xsimd-src/include -isystem /opt/homebrew/include -isystem /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/dependencies_install/include -isystem /opt/homebrew/Cellar/openssl@3/3.3.1/include -isystem /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/dependencies_install/include/proxygen -isystem /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox -isystem /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/external -isystem /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/external/date/velox/external -mcpu=apple-m1+crc -std=c++17 -fvisibility=hidden -Wno-nullability-completeness -Wno-deprecated-declarations -Wreorder -mcpu=apple-m1+crc -std=c++17 -fvisibility=hidden -D USE_VELOX_COMMON_BASE -D HAS_UNCAUGHT_EXCEPTIONS -Wall -Wextra -Wno-unused        -Wno-unused-parameter        -Wno-sign-compare        -Wno-ignored-qualifiers        -Wno-range-loop-analysis          -Wno-mismatched-tags          -Wno-nullability-completeness -g -std=gnu++17 -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk -fPIC -MD -MT velox/velox/connectors/hive/iceberg/CMakeFiles/velox_hive_iceberg_splitreader.dir/IcebergSplitReader.cpp.o -MF velox/velox/connectors/hive/iceberg/CMakeFiles/velox_hive_iceberg_splitreader.dir/IcebergSplitReader.cpp.o.d -o velox/velox/connectors/hive/iceberg/CMakeFiles/velox_hive_iceberg_splitreader.dir/IcebergSplitReader.cpp.o -c /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/IcebergSplitReader.cpp
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/IcebergSplitReader.cpp:17:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/IcebergSplitReader.h:21:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/PositionalDeleteFileReader.h:26:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/Reader.h:27:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/SelectiveColumnReader.h:22:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/FormatData.h:21:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/SeekableInputStream.h:23:
/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/wrap/zero-copy-stream-wrapper.h:31:10: fatal error: 'google/protobuf/io/zero_copy_stream.h' file not found
#include <google/protobuf/io/zero_copy_stream.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
@github-project-automation github-project-automation bot moved this to 🆕 Unprioritized in Build, releases and testing Aug 27, 2024
@agrawalreetika
Copy link
Member Author

I was able to pass this issue after I created below symlink manually,

ln -s /opt/homebrew/Cellar/protobuf@21/21.12/include/google /opt/homebrew/include/google

So I wanted to confirm, did this happen because of Mac OS upgrade or some other issue here?

@majetideepak
Copy link
Collaborator

Dependency leak. I will fix this.

@majetideepak majetideepak self-assigned this Aug 27, 2024
@majetideepak majetideepak added the prestissimo Presto Native Execution label Aug 27, 2024
@majetideepak majetideepak mentioned this issue Aug 27, 2024
Closed
@majetideepak
Copy link
Collaborator

majetideepak commented Aug 27, 2024 •
edited
Loading

@agrawalreetika I have a potential PR up here to fix facebookincubator/velox#10859

facebook-github-bot pushed a commit to facebookincubator/velox that referenced this issue Sep 10, 2024
@majetideepak @facebook-github-bot
Remove SeekableInputStream.h include from FormatData.h (#10859)
7e4d626 
Summary:
SeekableInputStream.h is causing the protobuf dependency to leak into Velox clients.
Move the PositionProvider class to its own file.

```
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/IcebergSplitReader.cpp:17:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/IcebergSplitReader.h:21:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/PositionalDeleteFileReader.h:26:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/Reader.h:27:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/SelectiveColumnReader.h:22:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/FormatData.h:21:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/SeekableInputStream.h:23:
/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/wrap/zero-copy-stream-wrapper.h:31:10: fatal error: 'google/protobuf/io/zero_copy_stream.h' file not found
#include <google/protobuf/io/zero_copy_stream.h>
```
See prestodb/presto#23528

Pull Request resolved: #10859

Reviewed By: xiaoxmeng

Differential Revision: D61936364

Pulled By: kgpai

fbshipit-source-id: ec7c913110fe0a38a5ba00a37addbfeac55e7289
@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to ✅ Done in Build, releases and testing Sep 23, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Prestissimo Gap Sep 23, 2024
athmaja-n pushed a commit to athmaja-n/velox that referenced this issue Jan 10, 2025
@majetideepak @athmaja-n
Remove SeekableInputStream.h include from FormatData.h (facebookincub…
ffd90c5 
…ator#10859)

Summary:
SeekableInputStream.h is causing the protobuf dependency to leak into Velox clients.
Move the PositionProvider class to its own file.

```
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/IcebergSplitReader.cpp:17:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/IcebergSplitReader.h:21:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/connectors/hive/iceberg/PositionalDeleteFileReader.h:26:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/Reader.h:27:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/SelectiveColumnReader.h:22:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/FormatData.h:21:
In file included from /Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/SeekableInputStream.h:23:
/Users/reetikaagrawal/Documents/Projects/Oss/prestodb-hivepoc/prestodb/presto-native-execution/velox/velox/dwio/common/wrap/zero-copy-stream-wrapper.h:31:10: fatal error: 'google/protobuf/io/zero_copy_stream.h' file not found
#include <google/protobuf/io/zero_copy_stream.h>
```
See prestodb/presto#23528

Pull Request resolved: facebookincubator#10859

Reviewed By: xiaoxmeng

Differential Revision: D61936364

Pulled By: kgpai

fbshipit-source-id: ec7c913110fe0a38a5ba00a37addbfeac55e7289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@majetideepak majetideepak

Labels
build prestissimo Presto Native Execution
Projects
Build, releases and testing
Status: ✅ Done
Prestissimo Gap
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@majetideepak @agrawalreetika