Skip to content

Commit

Permalink
[native] Add support for TPC-H Connector Protocol Bindings
Browse files Browse the repository at this point in the history
The protocol bindings for TPC-H Connector were manually added in PR #18367.
These bindings will now be generated automatically.
The following improvements have been made:

1. Improve README of presto_cpp/presto_protocol.
2. Add default make target to generate Presto protocol files.
3. Include TpchConnector classes in the yml file.
4. Extend special Connector files to support tpch.
5. Customize TpchTransactionHandle since the corresponding class in Java is an enum.
6. Customize TpchColumnHandle since we require an implementation of operator<().
  • Loading branch information
majetideepak committed Nov 11, 2022
1 parent 2f14947 commit c9ebcd3
Show file tree
Hide file tree
Showing 15 changed files with 15,105 additions and 14,663 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# limitations under the License.
.PHONY: presto_protocol presto_protocol-json presto_protocol-cpp

default: presto_protocol

presto_protocol: presto_protocol-cpp

Expand Down
10 changes: 7 additions & 3 deletions presto-native-execution/presto_cpp/presto_protocol/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ Dependencies to Install

You will need to note the path to the installed executable and add this to your PATH.
Something like `/Users/adutta/Library/Python/3.8/bin`.

Presto repo must be present at $HOME/presto. The PRESTO_HOME environment variable can
be set to override this location.

Presto Protocol Code Generation:
Run `make` in terminal.

Implementation Notes:

Expand All @@ -40,9 +46,7 @@ source generation.
* Abstract classes, their subclasses and the subclass type key are listed in
AbstractClasses.

* Java files from Presto are listed in JavaClasses. The script defaults the
presto repo checkout to $HOME/presto. The PRESTO_HOME environment variable can
be set to override this location.
* Java files from the Presto repo are listed in JavaClasses.

* ExtraProps lists a few additional java class properties that failed to be
extracted via Jackson annotations.
Expand Down
Loading

0 comments on commit c9ebcd3

Please sign in to comment.