Skip to content

Commit

Permalink
Fix AbstractTestQueries.testRandomizeNullKeyOuterJoin
Browse files Browse the repository at this point in the history
  • Loading branch information
tdcmeehan committed Mar 22, 2024
1 parent 8fc6cd3 commit 8b3b079
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6339,22 +6339,22 @@ public void testRandomizeNullKeyOuterJoin()
.build();

String leftJoin = "SELECT o.orderkey, l.discount FROM orders o LEFT JOIN lineitem l ON o.orderkey = l.orderkey";
assertQuery(enableRandomize, leftJoin, getSession(), leftJoin);
assertQueryWithSameQueryRunner(enableRandomize, leftJoin, getSession());

String multipleJoin = "SELECT o.orderkey, l.partkey, p.name FROM orders o LEFT JOIN lineitem l ON o.orderkey = l.orderkey LEFT JOIN part p ON l.partkey=p.partkey";
assertQuery(enableRandomize, multipleJoin, getSession(), multipleJoin);
assertQueryWithSameQueryRunner(enableRandomize, multipleJoin, getSession());

Session enableKeyFromOuterJoin = Session.builder(getSession())
.setSystemProperty(RANDOMIZE_OUTER_JOIN_NULL_KEY_STRATEGY, "key_from_outer_join")
.build();
assertQuery(enableKeyFromOuterJoin, multipleJoin, getSession(), multipleJoin);
assertQueryWithSameQueryRunner(enableKeyFromOuterJoin, multipleJoin, getSession());

Session enableRandomizeFourPartition = Session.builder(getSession())
.setSystemProperty(RANDOMIZE_OUTER_JOIN_NULL_KEY, "true")
.setSystemProperty(HASH_PARTITION_COUNT, "1")
.build();
String varcharJoinKey = "select t.k, t2.k, t2.v from (values 'r0', 'r1', 'r2', 'r3') t(k) left join (values (null, 1), (null, 2), (null, 3), (null, 4)) t2(k, v) on t.k = t2.k";
assertQuery(enableRandomizeFourPartition, varcharJoinKey, "values ('r0', null, null), ('r1', null, null), ('r2', null, null), ('r3', null, null)");
assertQueryWithSameQueryRunner(enableRandomizeFourPartition, varcharJoinKey, "values ('r0', null, null), ('r1', null, null), ('r2', null, null), ('r3', null, null)");
}

@Test
Expand Down

0 comments on commit 8b3b079

Please sign in to comment.