Skip to content

Commit

Permalink
Add logging to AbstractVerification
Browse files Browse the repository at this point in the history
Add logging to AbstractVerification to help with debugging flakiness in
TestCreateViewVerification.testRunningInQueryBankMode().
#20863
  • Loading branch information
rschlussel committed Apr 4, 2024
1 parent 42e7648 commit 4bd9115
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
package com.facebook.presto.verifier.framework;

import com.facebook.airlift.log.Logger;
import com.facebook.presto.jdbc.QueryStats;
import com.facebook.presto.sql.SqlFormatter;
import com.facebook.presto.sql.tree.Statement;
Expand Down Expand Up @@ -73,6 +74,7 @@
public abstract class AbstractVerification<B extends QueryBundle, R extends MatchResult, V>
implements Verification
{
private static final Logger LOG = Logger.get(AbstractVerification.class);
private static final String INTERNAL_ERROR = "VERIFIER_INTERNAL_ERROR";
private static final String SNAPSHOT_DOES_NOT_EXIST = "SNAPSHOT_DOES_NOT_EXIST";

Expand Down Expand Up @@ -277,6 +279,7 @@ else if ((isControlEnabled()) && !skipChecksum) {
catch (Throwable t) {
if (exceptionClassifier.shouldResubmit(t)
&& verificationContext.getResubmissionCount() < verificationResubmissionLimit) {
LOG.info("Error during verification: %s", t);
return new VerificationResult(this, true, Optional.empty());
}
throwable = Optional.of(t);
Expand Down

0 comments on commit 4bd9115

Please sign in to comment.