Skip to content

Commit

Permalink
Fix CI for next snapshot iteration PRs
Browse files Browse the repository at this point in the history
The new release process for presto creates pull requests
that have an incremented snapshot which hasn't
been built by anything yet. There are tests that are building
test coverage but skipping presto server. This creates a problem
where they are requesting dependencies that aren't built yet.

We don't need test-coverage in these tests, so it's best if
we just skip building those modules.
  • Loading branch information
g1y authored and tdcmeehan committed Oct 26, 2022
1 parent 50b0e44 commit 1c9de99
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/product-tests-basic-environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ jobs:
- name: Maven install
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing'
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
- name: Run Product Tests Basic Environment
run: presto-product-tests/bin/run_on_docker.sh multinode -x quarantine,big_query,storage_formats,profile_specific_tests,tpcds,cassandra,mysql_connector,postgresql_connector,mysql,kafka,avro
2 changes: 1 addition & 1 deletion .github/workflows/product-tests-specific-environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Mave install
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing'
./mvnw install ${MAVEN_FAST_INSTALL} -am -pl '!presto-docs,!presto-server-rpm,!presto-spark-package,!presto-spark-launcher,!presto-spark-testing,!presto-test-coverage'
- name: Product Tests Specific 1.1
run: presto-product-tests/bin/run_on_docker.sh singlenode -g hdfs_no_impersonation,avro
- name: Product Tests Specific 1.2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-native.yml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ jobs:
- name: Maven Install
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw install ${MAVEN_FAST_INSTALL} -pl '!presto-docs,!presto-server,!presto-server-rpm'
./mvnw install ${MAVEN_FAST_INSTALL} -pl '!presto-docs,!presto-server,!presto-server-rpm,!presto-test-coverage'
- name: Run e2e tests
run: |
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/test-other-modules.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Maven Install
run: |
export MAVEN_OPTS="${MAVEN_INSTALL_OPTS}"
./mvnw install ${MAVEN_FAST_INSTALL} -pl '!:presto-docs,!:presto-server,!:presto-server-rpm'
./mvnw install ${MAVEN_FAST_INSTALL} -pl '!:presto-docs,!:presto-server,!:presto-server-rpm,!presto-test-coverage'
- name: Maven Tests
run: |
./mvnw test ${MAVEN_TEST} -pl '
Expand All @@ -58,4 +58,5 @@ jobs:
!presto-elasticsearch,
!presto-orc,
!presto-thrift-connector,
!presto-native-execution'
!presto-native-execution,
!presto-test-coverage'

0 comments on commit 1c9de99

Please sign in to comment.