Fix bug in CBO stats

prestodb · Dec 21, 2022 · 15788ac · 15788ac
1 parent c4401f6
commit 15788ac
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/presto-main/src/main/java/com/facebook/presto/cost/PlanNodeStatsEstimate.java b/presto-main/src/main/java/com/facebook/presto/cost/PlanNodeStatsEstimate.java
@@ -127,7 +127,7 @@ public double getOutputSizeInBytes(PlanNode planNode)
     {
         requireNonNull(planNode, "planNode is null");
 
-        if (sourceInfo.isConfident() && !isNaN(totalSize)) {
+        if (!sourceInfo.estimateSizeUsingVariables() && !isNaN(totalSize)) {
             return totalSize;
         }
 

diff --git a/presto-spi/src/main/java/com/facebook/presto/spi/statistics/CostBasedSourceInfo.java b/presto-spi/src/main/java/com/facebook/presto/spi/statistics/CostBasedSourceInfo.java
@@ -49,4 +49,10 @@ public boolean isConfident()
     {
         return confident;
     }
+
+    @Override
+    public boolean estimateSizeUsingVariables()
+    {
+        return true;
+    }
 }
diff --git a/presto-spi/src/main/java/com/facebook/presto/spi/statistics/SourceInfo.java b/presto-spi/src/main/java/com/facebook/presto/spi/statistics/SourceInfo.java
@@ -20,4 +20,13 @@
 public abstract class SourceInfo
 {
     public abstract boolean isConfident();
+
+    /**
+     * Whether to estimate size of plan output using variable statistics.
+     * If false, we will use estimated size in plan statistics itself.
+     */
+    public boolean estimateSizeUsingVariables()
+    {
+        return false;
+    }
 }