Fix Symfony 6.1 deprecation #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4e6150 to
489df9d
Compare
norkunas
commented
Jun 7, 2022
yann-eugone
requested changes
Jun 7, 2022
c187a86 to
9cd8f93
Compare
norkunas
commented
Jun 7, 2022
| @@ -45,7 +43,7 @@ jobs: | |||
| symfony/http-kernel:${{ matrix.symfony-version }} \ | |||
| symfony/routing:${{ matrix.symfony-version }} \ | |||
| symfony/messenger:${{ matrix.symfony-version }} | |||
| composer update --no-interaction --no-progress --no-suggest | |||
There was a problem hiding this comment.
You are using the deprecated option "--no-suggest". It has no effect and will break in Composer 3.
There was a problem hiding this comment.
Yes, it's kind of the thing I'm fixing everywhere these days... If you can, remove it !
|
I think it's good now, and phpstan errors should be fixed in another PR or moved to baseline |
|
Also cannot use latest phpstan on 7.1 because it requires at least php 7.2 |
|
Fine, will fix it myself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.