Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed usage of Doctrine's ManagerRegistry #190

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Removed usage of Doctrine's ManagerRegistry #190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions Resources/doc/4-dynamic-routes-usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ please have a look to Symfony's [official documentation](http://symfony.com/doc/

namespace App\EventListener;

use App\Entity\BlogPost;
use Doctrine\Common\Persistence\ManagerRegistry;
use App\Repository\BlogPostRepository;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
use Presta\SitemapBundle\Event\SitemapPopulateEvent;
Expand All @@ -35,18 +34,18 @@ class SitemapSubscriber implements EventSubscriberInterface
private $urlGenerator;

/**
* @var ManagerRegistry
* @var BlogPostRepository
*/
private $doctrine;
private $blogPostRepository;

/**
* @param UrlGeneratorInterface $urlGenerator
* @param ManagerRegistry $doctrine
* @param BlogPostRepository $blogPostRepository
*/
public function __construct(UrlGeneratorInterface $urlGenerator, ManagerRegistry $doctrine)
public function __construct(UrlGeneratorInterface $urlGenerator, BlogPostRepository $blogPostRepository)
{
$this->urlGenerator = $urlGenerator;
$this->doctrine = $doctrine;
$this->blogPostRepository = $blogPostRepository;
}

/**
Expand All @@ -72,7 +71,7 @@ class SitemapSubscriber implements EventSubscriberInterface
*/
public function registerBlogPostsUrls(UrlContainerInterface $urls): void
{
$posts = $this->doctrine->getRepository(BlogPost::class)->findAll();
$posts = $this->blogPostRepository->findAll();

foreach ($posts as $post) {
$urls->addUrl(
Expand Down Expand Up @@ -106,7 +105,7 @@ Otherwhise you will have to register it by hand.
<services>
<service id="app.sitemap.blog_post_subscriber" class="App\EventListener\SitemapSubscriber">
<argument type="service" id="router"/>
<argument type="service" id="doctrine"/>
<argument type="service" id="<your repository service id>"/>
<tag name="kernel.event_subscriber" priority="100"/>
</service>
</services>
Expand All @@ -120,7 +119,7 @@ services:
class: App\EventListener\SitemapSubscriber
arguments:
- "@router"
- "@doctrine"
- "@<your repository service id>"
tags:
- { name: "kernel.event_subscriber", priority: 100 }
```
Expand Down