Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Presta\SitemapBundle\Event\SitemapPopulateEvent::getGenerator #116

Merged
merged 3 commits into from
Jun 15, 2016
Merged

Deprecate Presta\SitemapBundle\Event\SitemapPopulateEvent::getGenerator #116

merged 3 commits into from
Jun 15, 2016

Conversation

yann-eugone
Copy link
Member

Fixes #115

@yann-eugone yann-eugone mentioned this pull request Jun 13, 2016
Closed
Koc
Koc reviewed Jun 13, 2016
View reviewed changes
Event/SitemapPopulateEvent.php
* @return UrlContainerInterface
*/
public function getGenerator()
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should trigger deprection notice here

@yann-eugone yann-eugone mentioned this pull request Jun 13, 2016
Closed
@yann-eugone
Copy link
Member Author

@Koc seems good ?

@Koc
Copy link
Contributor

Koc commented Jun 14, 2016

Yes, only one thing: Symfony usually add @ before deprecation warning - https://github.com/symfony/symfony/search?p=1&q=E_USER_DEPRECATED&utf8=%E2%9C%93

@yann-eugone yann-eugone merged commit 33f26ab into master Jun 15, 2016
@yann-eugone yann-eugone deleted the issue-115 branch June 15, 2016 07:43
@yann-eugone yann-eugone mentioned this pull request Jun 16, 2016
Closed
@yann-eugone yann-eugone mentioned this pull request Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yann-eugone @Koc