Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for php7.4 #58

Merged
merged 4 commits into from
Aug 7, 2021
Merged

Prep for php7.4 #58

merged 4 commits into from
Aug 7, 2021

Conversation

SteelWagstaff
Copy link
Member

This PR improves the CI flow and adds an experimental test that runs against PHP 7.4, Ubuntu 20,04 and the latest version of WP.

Partial fix for https://github.com/pressbooks/private/issues/602

@SteelWagstaff SteelWagstaff requested a review from arzola August 6, 2021 21:26
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #58 (fb61dbe) into dev (00f712c) will increase coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #58      +/-   ##
============================================
+ Coverage     82.41%   83.10%   +0.68%     
  Complexity      104      104              
============================================
  Files             3        3              
  Lines           290      290              
============================================
+ Hits            239      241       +2     
+ Misses           51       49       -2     
Impacted Files Coverage Δ
inc/class-cas.php 78.50% <0.00%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f712c...fb61dbe. Read the comment docs.

Fix test matrix name
Bump WP version
@SteelWagstaff SteelWagstaff merged commit 1d0067d into dev Aug 7, 2021
@SteelWagstaff SteelWagstaff deleted the prep-for-php7.4 branch August 7, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant