Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis with GitHub Actions #56

Merged
merged 8 commits into from
Jul 13, 2021
Merged

Conversation

SteelWagstaff
Copy link
Member

@SteelWagstaff SteelWagstaff commented Jul 12, 2021

This PR replaces Travis with GitHub Actions and adds Pressbooks Build Tools as a dev dependency (see pressbooks/pressbooks#2235). It also makes some modifications to the package.json scripts to be compatible with Laravel Mix 6. Fix for #55 and partial fix for https://github.com/pressbooks/private/issues/466

package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #56 (befba57) into dev (30322c2) will not change coverage.
The diff coverage is n/a.

❗ Current head befba57 differs from pull request most recent head 900d52d. Consider uploading reports for the commit 900d52d to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##                dev      #56   +/-   ##
=========================================
  Coverage     82.41%   82.41%           
  Complexity      104      104           
=========================================
  Files             3        3           
  Lines           290      290           
=========================================
  Hits            239      239           
  Misses           51       51           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30322c2...900d52d. Read the comment docs.

@arzola
Copy link
Contributor

arzola commented Jul 13, 2021

Looks good, Tests are passing nice work Steel

@SteelWagstaff
Copy link
Member Author

Thanks. Will you squash & merge and delete this branch @arzola ?

@arzola arzola merged commit 00f712c into dev Jul 13, 2021
@arzola arzola deleted the pressbooks-cas-sso-55-github-actions branch July 13, 2021 21:35
@SteelWagstaff SteelWagstaff mentioned this pull request Jul 13, 2021
3 tasks
@SteelWagstaff SteelWagstaff linked an issue Jul 13, 2021 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to GitHub Actions
2 participants