Add integration tests for github public/private repositories #99
+133
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 13, 2020 16:32
…ather than being shared in the reused scenario for more clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
In order to avoid regressions in integrations with supported issue trackers (Pivotal, Redmine, Github, Gitlab, etc) and avoid the need for extensive manual testing before accepting any PR, I've started preparing a test suite which verifies that todocheck can correctly integrate with all supported issue trackers for both private and public repositories.
In this PR, I'm creating the test suite for integrating with private & public github repositories. To do that, I have created a github secret which contains the api key for reading the repositories and is available to the tests in the github action.
Additionally, I had to fix an issue where the
setupMockIssueTrackerServerin the scenario builder was always setting up a mock server regardless if one was needed. This lead to some small regressions in the rest of the integration tests due to an invalid issue tracker origin as per our validations.Finally, these tests have been setup to only run in CI (github actions) because they rely on a sensitive secret which is available in the CI environment thanks to Github secrets, but is not available in the local environment of any of the maintainers.
Related to #120