unblock issues caused by bad validation #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdy
reviewed
Oct 25, 2020
zen37
pushed a commit
to zen37/todocheck
that referenced
this pull request
Oct 28, 2020
preslavmihaylov
pushed a commit
that referenced
this pull request
Oct 29, 2020
preslavmihaylov
pushed a commit
that referenced
this pull request
Oct 31, 2020
* unblock issues caused by bad validation * remove commented out code
preslavmihaylov
pushed a commit
that referenced
this pull request
Oct 31, 2020
mehdy
pushed a commit
that referenced
this pull request
Nov 1, 2020
… code into separate components (#81) * refactored issue tracker component, applying dependency inversion * fix failing build for tests * renamed all occurrencces of redmine to pivotaltracker in the pivotaltracker component * fix issue #71 (#84) Co-authored-by: zen <zen@zen> * unblock issues caused by bad validation (#85) * unblock issues caused by bad validation * remove commented out code * Enable annotating issues with hashtag (#86) * Enable annotating github issues with hashtag * add test * revert ParseGithubDetails to parseGithubDetails * revert README and auto_detect_config's change * Add test for hashtag todos with github * Add ExpectJSONOutput (#77) * Add ExpectJSONOutput * rename ExpectJsonOutput to WithJSONOutput, divide validateTodoErrs into two funcs * modify the way to compare json todo errs and scenarios * Add TestAnnotatedTodosWithJSONOutput Co-authored-by: Preslav Mihaylov <preslav@uber.com> * re-fixes issue #71 broken by PR #85 (#87) * re-fixes issue #71 broken by PR #85 * re-fixes issue #71, removes validation of auth type from validation.go Co-authored-by: zen <zen@zen> Co-authored-by: Preslav Mihaylov <preslav@uber.com> * refactored issue tracker component, applying dependency inversion Co-authored-by: zen37 <mobi2009ro@gmail.com> Co-authored-by: zen <zen@zen> Co-authored-by: liao <liao_shizhen@yahoo.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 for #78
The fix I've made here addresses the issue with the warning always present and partially, the one with always failing validation for private github repositories.
What's left is to also include the authentication middleware in calls to
fetcher.IsHealthyI will do that after finishing the refactorings started in #81.
For the time being, I've removed that validation to unblock master from not working with private github repositories.