Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract the config.Validate function into a separate package #73

Closed
wants to merge 3 commits into from
Closed

extract the config.Validate function into a separate package #73

wants to merge 3 commits into from

Conversation

preslavmihaylov
Copy link
Owner

This refactor would allow future changes to the Validate function to include dependencies on issuetracker and others which is not currently possible as that would lead to cyclic dependencies.

@preslavmihaylov preslavmihaylov requested a review from mehdy October 16, 2020 05:48
@preslavmihaylov preslavmihaylov mentioned this pull request Oct 16, 2020
Merged
@preslavmihaylov
Copy link
Owner Author

preslavmihaylov commented Oct 17, 2020 •
edited
Loading

Abandoned due to tedious git rebasing issues. See #74 instead...

@preslavmihaylov preslavmihaylov deleted the refactor-validation-func branch October 17, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehdy mehdy Awaiting requested review from mehdy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@preslavmihaylov