Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI integration tests for testing redmine issue tracker integration #126

Merged
merged 8 commits into from
Jan 7, 2021

Conversation

preslavmihaylov
Copy link
Owner

@preslavmihaylov preslavmihaylov commented Jan 6, 2021

The issue tracker server instance is hosted on my private server & the new integration tests verify todocheck's integration by calling the server's rest api.

The api token which is added is of a user with the 'Viewer' role for the project he's been added to.

The pull_request_target test is expected to fail as it doesn't use the newly added secret to the project. It's push counterpart passes, which shows that the new CI tests work correctly.

Additional minor changes:

  • added the ability to specify an issue with # for redmine.
  • fixed the expected default format specified in one of the README sections

Related to #120

@preslavmihaylov preslavmihaylov changed the title add CI integration tests for testing public redmine integration add CI integration tests for testing redmine issue tracker integration Jan 6, 2021
@preslavmihaylov preslavmihaylov requested a review from mehdy January 6, 2021 17:28
Copy link
Collaborator

@mehdy mehdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@preslavmihaylov preslavmihaylov merged commit 2a9c451 into master Jan 7, 2021
@preslavmihaylov preslavmihaylov deleted the add-redmine-public-ci-tests branch January 7, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants