You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the CI steps fail because the new secret is not available for pull_request_target runs. As observed, when the event is push, the step passes. After this is merged, the failing step will, hence, start passing.
In addition to this, I've decided to reduce the test verbosity to more easily identify which tests are failing.
Yeah, I've mentioned that in the description - tests whichare run with pull_request_target run with the workflow as-is from the master branch. The workflow from there doesn't have the new secret I've added.
After the diff is merged, the test will start passing, as is seen by the push variant of the step.
Yeah, I've mentioned that in the description - tests whichare run with pull_request_target run with the workflow as-is from the master branch. The workflow from there doesn't have the new secret I've added.
After the diff is merged, the test will start passing, as is seen by the push variant of the step.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #120
One of the CI steps fail because the new secret is not available for pull_request_target runs. As observed, when the event is
push, the step passes. After this is merged, the failing step will, hence, start passing.In addition to this, I've decided to reduce the test verbosity to more easily identify which tests are failing.
Closes #117