Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing file read operations to avoid state change #45

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

krithika7402
Copy link
Collaborator

@krithika7402 krithika7402 commented Feb 24, 2025

Description

The chat breaks after editing a user story because a ReadFile is performed, which updates the selectedFileContent in the global state. This was added to read the updated content and update the user story component accordingly. However, this action overwrites the selectedFileContent, which is supposed to hold the PRDxx-base.json content, with the PRDxx-feature.json content. When navigating to the Task page, it tries to access the requirement attribute from the PRDxx-base.json content in the selectedFileContent. Due to the overwrite, the requirement attribute becomes undefined, causing the chat to break as the payload's attribute is undefined. This PR fixes this issue.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update

Pre-flight Checklist

  • Changes are limited to a single feature, bugfix or chore (split larger changes into separate PRs)
  • I have reviewed contributor guidelines

Screenshots

Additional Notes

@krithika7402 krithika7402 self-assigned this Feb 24, 2025
Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 1a7c2d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
specif-ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

anand-presidio
anand-presidio previously approved these changes Feb 24, 2025
@anand-presidio
Copy link
Collaborator

can you please add a changeset?

@krithika7402
Copy link
Collaborator Author

@anand-presidio changeset has been added, please verify!

@anand-presidio anand-presidio merged commit 9a2a544 into presidio-oss:main Feb 24, 2025
@krithika7402 krithika7402 deleted the fix/task-chat branch February 28, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants