Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If we're gonna pre-build the library, we shouldn't have /lib in .gitignore #3

Closed
wants to merge 1 commit into from

Conversation

mechanical-turk
Copy link

No description provided.

@prescottprue
Copy link
Owner

prescottprue commented Oct 6, 2017

What is the goal of this? The lib folder contains the commonjs build of library, so removing this from gitignore would then track those build results in git tracking.

Just because it is in git tracking doesn't mean that it won't be published to npm. That is what the .npmignore is for (which there isn't one yet), then the fall back would be the files parameter of the package.json (again not there in this repo). All of that means that all of the files in the repo will be included when releasing to npm even ones not tracked by git.

Am I missing something?

@mechanical-turk
Copy link
Author

@prescottprue you're right. the thing that made me think this would solve the issue was that even though the main key in the package.json points to lib/index.js, the entire lib folder is missing, both in the git repo and the npm module.

Once you find the time, you could build and re-publish the package so that npm also gets the lib folder. And I'll start testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants