-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firestore reducer for typescript #296
Add firestore reducer for typescript #296
Conversation
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 19 19
Lines 626 626
=======================================
Hits 564 564
Misses 62 62 Continue to review full report at Codecov.
|
@feelthepain444 You might want to check this out this PR I closed: prescottprue/react-redux-firebase#964. I'd be happy to collaborate with you on this - I meant to open this against the Regardless, you'd want to return a |
@bawahakim is no longer using I am guessing here but I assume he understandably won't want to spend anymore time on this. I will fork his repo over the weekend and add the changes you've suggested. |
Did anything ever progress with this? |
Types based on work shared by @msutkowski, and @bawahakim Co-Authored-By: Matt Sutkowski <784953+msutkowski@users.noreply.github.com> Co-Authored-By: Hakim Bawa <43802542+bawahakim@users.noreply.github.com>
* fix(getFirestore): correctly load extended firestore instance in `getFirestore` (#318) - @aarajh * fix(orderedReducer): reorder items when `newIndex` is zero (#317) - @matthew-h-cromer * feat(types): add types for reducer (#296, [react-redux-firebase 964](prescottprue/react-redux-firebase#964)) - @msutkowski,@bawahakim * fix(examples): update complete example patterns + major versions * build(deps): bump immer from 5.0.0 to 8.0.1 (#320) * build(deps): bump ini from 1.3.5 to 1.3.8 (#316) * build(deps): bump ini from 1.3.5 to 1.3.8 in /examples/basic (#315) Co-Authored-By: Hakim Bawa <43802542+bawahakim@users.noreply.github.com> Co-authored-by: Aaraj Habib <aarajh@gmail.com> Co-authored-by: matthew-h-cromer <35811043+matthew-h-cromer@users.noreply.github.com> Co-authored-by: Matt Sutkowski <784953+msutkowski@users.noreply.github.com>
v0.15.0 release has the functionality based on code here and @msutkowski mentioned PR - because of that both of you were listed as co-authors of the commit while I was manually combining it This is a first swing at the types, but it seemed to be working in a simple example. Please reach out if things aren't working as expected! |
Description
I couldn't properly get firestore to work with Typescript, so I went ahead and tried implementing it.
Check List
If not relevant to pull request, check off as complete
Relevant Issues