Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #18

Merged
merged 4 commits into from
Apr 22, 2019
Merged

Develop #18

merged 4 commits into from
Apr 22, 2019

Conversation

assertchris
Copy link
Member

No description provided.

@ircmaxell
Copy link
Contributor

Why did you delete the expanders that were included here? Was that intentional, or did they move elsewhere?

@assertchris
Copy link
Member Author

I'm in the process of moving them here: https://github.com/preprocess/pre-standard


return $code;
}
exec($command, $output);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the assumption that the current working directory is in the pre folder. Since that's not the case when this is a dependency, you'd need to store the current working directory.

I basically changed exec to:

        $cwd = getcwd();
        chdir(__DIR__);
        exec($command, $output);
        chdir($cwd);

Otherwise node will node be able to find node_modules and will error out...

@assertchris assertchris merged commit 189d12a into master Apr 22, 2019
@assertchris assertchris deleted the develop branch July 11, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants