feat: create venv from rust #128
Conversation
crates/rattler_installs_packages/src/python_env/system_python.rs
Outdated
Show resolved
Hide resolved
|
I'll want to test the branch a bit tomorrow and will look at te rest of the changes, but from what I am seeing it looks pretty good! |
Thank you very much! Let me know if there is anything I can help with |
|
Okay looks good, merging! |
| .or_else(|_| which::which("python")) | ||
| .map_err(|_| FindPythonError::NotFound) | ||
|
|
||
| let output = match std::process::Command::new("python3") |
There was a problem hiding this comment.
Not something that needed to happen in this PR but... given the move away from a few stat calls to a subprocess, consider caching the results of system_python_executable across the entire process since it's unlikely to change and you can avoid this overhead on every environment creation + bytecode compile call etc.
There was a problem hiding this comment.
Thanks @pradyunsg will make an issue (#134) out of this!
Create python venv directly from rust.
Implementation based on built-in venv module.
I've changed a little
system_python_executableimplementation.whichdoes not return original interpreter but a shim path when using pyenv. This does not work well when we later createpyenv.cfgand sethome =Closes: #83