Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make preCICE export paths consistent #510

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Apr 3, 2024

I am renaming all directories in<export: tags to precice-exports, as currently suggested by our documentation.

  • flow-over-heated-plate:
    • rename in config and README
    • enable exports by default, instead of the user having to explicitly add these (the case is small and short anyway)
    • check the visualization script and update the picture, including OpenFOAM-DuneFem. @BenjaminRodenberg why was that disabled before in the script, while we had it in the picture? Also, there were points used for OpenFOAM-FEniCS, but this is arbitrary in this context and does not originate from the script.
  • flow-over-heated-plate-nearest-projection:
    • rename in (commented-out) config and README. I did not enable it, since it is not directly used by any script in this tutorial.
  • quickstart:
    • rename in config and README
    • remove from the clean.sh. This is now covered by the clean_precice_logs.

I could not find any other relevant instances.

Closes #417.

@MakisH MakisH added this to the v202403.0 milestone Apr 3, 2024
@MakisH MakisH requested a review from BenjaminRodenberg April 3, 2024 21:23
@MakisH MakisH self-assigned this Apr 3, 2024
@MakisH
Copy link
Member Author

MakisH commented Apr 4, 2024

I have no idea why autopep8 complains in this PR, as I did not touch any Python files here and it has not recently failed on develop either.

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good step

@MakisH MakisH mentioned this pull request Apr 4, 2024
53 tasks
@MakisH MakisH merged commit def68a0 into precice:develop Apr 5, 2024
1 check passed
@MakisH MakisH deleted the consistent-exports branch April 5, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent name of preCICE exports
3 participants