Remove the scalar and vector keywords from data names in configuration #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The two-scale heat conduction tutorial case produces reasonable results:
|
uekerman
approved these changes
Jan 21, 2025
Comment on lines
+106
to
+107
| self._write_data_names, list | ||
| ), "Write data entry is not a list" |
There was a problem hiding this comment.
Once we have the schema, such error message will no longer be needed 😊
Co-authored-by: Benjamin Uekermann <benjamin.uekermann@ipvs.uni-stuttgart.de>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scalarandvectorkeyword values for data name dictionaries are no longer necessary as the preCICE v3.x API does not distinguish between the data dimensions it works with. No functionality in the Micro Manager relies on this user information.Checklist:
CHANGELOG.md.