Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set initial time window size of the micro simulation in the configuration #112

Merged
merged 8 commits into from
Jun 11, 2024

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Jun 10, 2024

This PR implements changes which allow for the user to set the initial time window size (dt) of the micro simulation during configuration. The time window size is then using in the coupling, which allows for subcycling.

Note: The micro simulation cannot modify the time window size during the coupling. A followup feature can change the micro simulation library API in a way that the solve(...) function call can return the desired time step value of the micro simulation.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • If necessary, I made changes to the documentation and/or added new content.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Jun 10, 2024
@IshaanDesai IshaanDesai added the new-feature Adding a new feature label Jun 10, 2024
@IshaanDesai IshaanDesai mentioned this pull request Jun 10, 2024
@IshaanDesai IshaanDesai marked this pull request as ready for review June 10, 2024 17:15
@IshaanDesai IshaanDesai changed the title Ask for the initial time window size of the micro simulation Set initial time window size of the micro simulation in the configuration Jun 10, 2024
@BenjaminRodenberg
Copy link
Member

@IshaanDesai Anything specific where you would need feedback? It's a bit hard for me to give a general review here because I'm not that much involved in this project.

@IshaanDesai IshaanDesai removed the request for review from BenjaminRodenberg June 11, 2024 09:13
@IshaanDesai IshaanDesai merged commit 26dd92d into develop Jun 11, 2024
10 checks passed
@IshaanDesai IshaanDesai deleted the add_micro_dt branch June 11, 2024 14:53
@IshaanDesai IshaanDesai mentioned this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Adding a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants