Manually install scipy in tests #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this approach is problematic. Ideally the python package should define the dependency on scipy on its own and the installation of scipy should happen automatically.
|
@IshaanDesai and @NiklasVin: This is meant mainly as an FYI. The solution is temporary and I will probably overhaul the testing at a later point in time and bring everything to a more modern infrastructure. |
`awalsh128/cache-apt-pkgs-action@latest` requires `sudo`
IshaanDesai
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this fix is to bring the test back to a working state. On the long run the plan is to modernize the testing infrastructure (see #189 and #177).
The approach implemented in this PR is problematic. Ideally the python package should define the dependency on scipy on its own and the installation of scipy should happen automatically.