Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests checking implementation of checkpointing/SolverState #173

Merged
merged 8 commits into from
Aug 20, 2024

Conversation

NiklasVin
Copy link
Collaborator

These tests are written in context of Pull Request #172
Since the core functionality of the checkpointing is implemented in the SolverState class, the tests are actually testing only this class.
This commit consists of three different tests:

  1. Write checkpoint & directly load it (just for the sake of completeness)
  2. Write checkpoint of a function, then modify the dof vector of the dolfin function by directly accessing it via vector(). After that, load the checkpoint.
  3. Write checkpoint of a function, then modify the this dolfin function via assign(). After that, load the checkpoint.

@BenjaminRodenberg
Copy link
Member

To make sure: At the moment we expect this test to fail. As soon as #172 is merged this test should succeed. Correct?

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor readability concerns. As soon as you merged the current state of develop into this PR the tests should work again.

@NiklasVin
Copy link
Collaborator Author

To make sure: At the moment we expect this test to fail. As soon as #172 is merged this test should succeed. Correct?

Yes

@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Aug 13, 2024

Ok. Then I will merge the tests soon. This leads to failure on develop but then we have #172 as a fix already prepared.

Copy link
Member

@BenjaminRodenberg BenjaminRodenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and also tests the right thing! Thanks for the contribution. Will merge this now.

@BenjaminRodenberg BenjaminRodenberg merged commit 98fcd95 into precice:develop Aug 20, 2024
4 of 5 checks passed
@BenjaminRodenberg BenjaminRodenberg added this to the v2.2.0 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants