-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests checking implementation of checkpointing/SolverState #173
Conversation
To make sure: At the moment we expect this test to fail. As soon as #172 is merged this test should succeed. Correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor readability concerns. As soon as you merged the current state of develop
into this PR the tests should work again.
Yes |
Ok. Then I will merge the tests soon. This leads to failure on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and also tests the right thing! Thanks for the contribution. Will merge this now.
These tests are written in context of Pull Request #172
Since the core functionality of the checkpointing is implemented in the SolverState class, the tests are actually testing only this class.
This commit consists of three different tests:
vector()
. After that, load the checkpoint.assign()
. After that, load the checkpoint.