Concert Adapter: New Server Adapter #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ChrisHuie
approved these changes
May 2, 2024
ConcertAnalyticsAdapter/ConcertBidAdapter: Update documentation
patmmccann
reviewed
May 29, 2024
| tcfeu_supported: true | ||
| usp_supported: true | ||
| gvl_id: N/A | ||
| coppa_supported: false |
There was a problem hiding this comment.
Please add some additional documentation. This is below a reasonable minimum
There was a problem hiding this comment.
@Skitelman tagging you here for visibility.
2 tasks
ConcertAnalyticsAdapter: More documentation
Added more documentation in this commit. Let me know if that is sufficient. Thank you. |
patmmccann
approved these changes
Jun 20, 2024
|
Thanks! |
muuki88
requested changes
Jul 8, 2024
dev-docs/analytics/concert.md
Outdated
| @@ -4,8 +4,21 @@ title: Concert | |||
| description: Concert Analytics Adapter | |||
| modulecode: concert | |||
| enable_download: false | |||
| prebid_member: false | |||
| tcfeu_supported: true | |||
There was a problem hiding this comment.
How can you support TCF if you don't have a vendor id? If consent cannot be checked for your vendor, then it's supported.
Suggested change
| tcfeu_supported: true | |
| tcfeu_supported: false |
dev-docs/bidders/concert.md
Outdated
| media_types: banner, audio, video | ||
| pbs_app_supported: true | ||
| deals_supported: true | ||
| tcfeu_supported: true |
There was a problem hiding this comment.
Either you add a gvl_id or this remains false
Merged
1 task
ConcertAnalyticsAdapter/ConcertBidAdapter: Corrected documentation
|
@muuki88 Made your recommended changes in this commit |
muuki88
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Concert Adapter docs in conjunction with our new Prebid Server adapter.
Prebid server adapter PR
🏷 Type of documentation
📋 Checklist