Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Inmar from Prebid - No longer supported #3985

Closed
wants to merge 1 commit into from

Conversation

prashuc
Copy link

@prashuc prashuc commented Aug 29, 2022

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Sorry, something went wrong.

@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 8aee609
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/630ce4fa76e1740008049416
😎 Deploy Preview https://deploy-preview-3985--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we can't let you delete the documentation -- the code is still in the main repo. Please update this PR:

  • put a note at the top that says something like "no longer supported"
  • add the enable_download: false header. That will take it off the download page
  • submit a PR to remove the code from the main Prebid.js repo

@prashuc
Copy link
Author

prashuc commented Sep 2, 2022

@bretg - updated the PR title (no longer supported). Also we already submitted PR for removing code from main Prebid.js repo (prebid/Prebid.js#8913).

@prashuc prashuc changed the title RTB-2173: Removing Inmar from Prebid Removing Inmar from Prebid - No longer supported Sep 2, 2022
@bretg
Copy link
Contributor

bretg commented Sep 2, 2022

The way we handle adapter removals is that we flag them as not downloadable or supported rather than removing them. Then in a major release (e.g. 8.0), then the docs can be removed.

It could be headscratching for a publisher using your adapter to have the docs suddenly disappear.

I'm going to close this PR and make one that gives such publishers a transition period.

@bretg bretg closed this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants