Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missena bid adapter #2679

Merged
merged 4 commits into from
Feb 11, 2021
Merged

Add Missena bid adapter #2679

merged 4 commits into from
Feb 11, 2021

Conversation

dev-missena
Copy link
Contributor

@dev-missena dev-missena commented Feb 1, 2021 •
edited
Loading

Adding documentation for the Missena bid adapter

@dev-missena dev-missena mentioned this pull request Feb 1, 2021
Merged
2 tasks
@jeanstemp
Copy link
Contributor

Hi! Can you add to the header whether this is for pbjs or pbs or both.
"Add pbjs: true. If you also have a Prebid Server bid adapter, add pbs: true. Default is false for both."
Also, there should be single quotes around the string example.
See https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter
Thanks!

@dev-missena
Copy link
Contributor Author

dev-missena commented Feb 4, 2021 •
edited
Loading

@jeanstemp Hi! I've added the missing params and fixed the missing single quotes. Thanks!

@dev-missena
Copy link
Contributor Author

@jeanstemp prebid/Prebid.js#6247 has been released.
Could we merge the PR? I guess this is what we need to add Missena to the selectable bidders on https://docs.prebid.org/download.html

Thanks!

@jeanstemp jeanstemp merged commit 595da6a into prebid:master Feb 11, 2021
osazos pushed a commit to onfocusio/prebid.github.io that referenced this pull request Feb 23, 2021
@dev-missena @osazos
Add Missena bid adapter (prebid#2679)
0356b89 
* Create missena.md

* Add setup details

* Fix token example not in single quote

* Add pbjs, tcf2_supported, gvl_id, safeframes not supported params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
LGTM not merged yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev-missena @jeanstemp