Kubient and Fidelity bid adapters. Update Gvlid, Parameters, Alias. #2552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
bretg
requested changes
Dec 4, 2020
dev-docs/bidders/fidelity.md
Outdated
| @@ -8,7 +8,6 @@ biddercode: fidelity | |||
| media_types: banner | |||
| gdpr_supported: true | |||
| usp_supported: true | |||
| gvl_id: 408 | |||
There was a problem hiding this comment.
Why are you removing the GVLID from the fidelity adapter? 408 seems valid for them -- https://vendorlist.consensu.org/v2/vendor-list.json
408: {
id: 408,
name: "Fidelity Media",
purposes: [
1,
2,
7
],
legIntPurposes: [ ],
flexiblePurposes: [
2,
7
],
specialPurposes: [ ],
features: [ ],
specialFeatures: [ ],
policyUrl: "https://fidelity-media.com/privacy-policy/",
deletedDate: "2020-08-25T00:00:00Z",
cookieMaxAgeSeconds: -100,
usesNonCookieAccess: false
},
There was a problem hiding this comment.
The fidelity adapter still refers to the id
const FIDELITY_VENDOR_ID = 408;
There was a problem hiding this comment.
@bretg Thanks, I'll look into and fix it on Monday
There was a problem hiding this comment.
@bretg it is fixed now. Please, re-review.
bretg
approved these changes
Dec 7, 2020
osazos
pushed a commit
to onfocusio/prebid.github.io
that referenced
this pull request
Jan 21, 2021
…rebid#2552) * Update Fidelity Bid Adapter. Remove GVLID * Update Kubient Adapter parameters, add GVLID. * Error fix. Gvlid is back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding native Kubient pbjs adapter, removing alias from Fidelity adapter.