Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedId UserId submodule documentation #2031

Merged
merged 6 commits into from
Jun 16, 2020
Merged

SharedId UserId submodule documentation #2031

merged 6 commits into from
Jun 16, 2020

Conversation

SKOCHERI
Copy link
Contributor

@SKOCHERI SKOCHERI commented Jun 4, 2020

No description provided.

@SKOCHERI SKOCHERI mentioned this pull request Jun 4, 2020
Merged
10 tasks
@jdwieland8282 jdwieland8282 self-requested a review June 8, 2020 19:37
@jdwieland8282 jdwieland8282 self-assigned this Jun 8, 2020
@jdwieland8282
Copy link
Member

seems good to me

jdwieland8282
jdwieland8282 approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@jdwieland8282 jdwieland8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me

@jdwieland8282 jdwieland8282 requested a review from jlukas79 June 8, 2020 19:41
@bretg
Copy link
Contributor

bretg commented Jun 12, 2020

@jdwieland8282 - does this obsolete #1923 ?

bretg
bretg requested changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add sharedId to the later sections of the document -- Bidder Adapter Implementation and Prebid Server Adapters.

@SKOCHERI
Copy link
Contributor Author

SKOCHERI commented Jun 12, 2020 •
edited
Loading

Please add sharedId to the later sections of the document -- Bidder Adapter Implementation and Prebid Server Adapters.

@bretg Have updated it to add sharedId to later section

@SKOCHERI SKOCHERI closed this Jun 12, 2020
@SKOCHERI SKOCHERI reopened this Jun 12, 2020
bretg
bretg requested changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - moving the section isn't at all what I meant. Please move it back to be alphabetical with the other userId modules.

Please read the sections I referred to.

  1. add an entry for sharedId into the table in the Bidder Adapter Implementation section
  2. add an en entry for sharedId into the user.ext.eids example in the Prebid Server Adapters section

@SKOCHERI
Copy link
Contributor Author

SKOCHERI commented Jun 12, 2020 •
edited
Loading

@bretg Have updated the documentation
Have added the shared is details to Bidder Adapter Implementation and Prebid Server Adapters section
Have ordered the usedId modules and included sharedid in alphabetical order.
Have moved netID user id module above to order alphabetically. I hope that should be ok

@jdwieland8282
Copy link
Member

#2031 (comment)

@jdwieland8282 - does this obsolete #1923 ?

yes

@jdwieland8282 jdwieland8282 mentioned this pull request Jun 12, 2020
Closed
@SKOCHERI SKOCHERI merged commit a24d4bf into prebid:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

@jdwieland8282 jdwieland8282 jdwieland8282 approved these changes

@jlukas79 jlukas79 jlukas79 approved these changes

Assignees

@jdwieland8282 jdwieland8282

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SKOCHERI @jdwieland8282 @bretg @jlukas79